Skip to content

Conversation

@sl0thentr0py
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 4, 2024

❌ 357 Tests Failed:

Tests completed Failed Passed Skipped
19358 357 19001 4432
View the top 1 failed tests by shortest run time
tests.integrations.threading.test_threading test_propagates_hub[False]
Stack Traces | 0.007s run time
.../integrations/threading/test_threading.py:71: in test_propagates_hub
    assert "stage1" not in event.get("tags", {})
E   AssertionError: assert 'stage1' not in {'stage1': 'true'}
E    +  where {'stage1': 'true'} = <built-in method get of dict object at 0x7fb478d5a000>('tags', {})
E    +    where <built-in method get of dict object at 0x7fb478d5a000> = {'breadcrumbs': {'values': []}, 'contexts': {'trace': {'parent_span_id': None, 'span_id': '963fa635e00c59fe', 'trace_id': 'f0e7a86e845b4de5b7acac81e79d2300'}}, 'environment': 'production', 'event_id': '5402fc30f2cf48b59293e6f07f727e08', ...}.get
View the full list of 2 ❄️ flaky tests
tests.integrations.threading.test_threading test_propagates_hub[False]

Flake rate in main: 99.30% (Passed 2 times, Failed 285 times)

Stack Traces | 0.007s run time
.../integrations/threading/test_threading.py:71: in test_propagates_hub
    assert "stage1" not in event.get("tags", {})
E   AssertionError: assert 'stage1' not in {'stage1': 'true'}
E    +  where {'stage1': 'true'} = <built-in method get of dict object at 0x7fdff8bc1f00>('tags', {})
E    +    where <built-in method get of dict object at 0x7fdff8bc1f00> = {'breadcrumbs': {'values': []}, 'contexts': {'trace': {'parent_span_id': None, 'span_id': '8e8353e345215baa', 'trace_id': '79c0598911094253833fb648633f1cd4'}}, 'environment': 'production', 'event_id': '10c4853968924207ac58f9379b6165fa', ...}.get
tests.integrations.threading.test_threading test_propagates_hub[False]

Flake rate in main: 40.62% (Passed 19 times, Failed 13 times)

Stack Traces | 0.008s run time
.../integrations/threading/test_threading.py:71: in test_propagates_hub
    assert "stage1" not in event.get("tags", {})
E   AssertionError: assert 'stage1' not in {'stage1': 'true'}
E    +  where {'stage1': 'true'} = <built-in method get of dict object at 0x7f8e70aa1500>('tags', {})
E    +    where <built-in method get of dict object at 0x7f8e70aa1500> = {'breadcrumbs': {'values': []}, 'contexts': {'trace': {'parent_span_id': None, 'span_id': 'aaab054f9584cb9e', 'trace_id': '901cd9fd5274469eb6bfd87f7a7c3eec'}}, 'environment': 'production', 'event_id': 'dc2b0d440cff4608abbdfd178608aee5', ...}.get

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is related code that has to be changed as well. (see other comment)

from tests.conftest import ApproxDict


SLOTS_NOT_COPIED = {"client"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove code related to SLOTS_NOT_COPIED

@sl0thentr0py
Copy link
Member Author

closing this in favor of one against master
#3857

@sl0thentr0py sl0thentr0py deleted the neel/potel/fix-scope-client branch January 21, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants